-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ETHOSN] Removed support for 20.08 version of the driver stack. #7858
Conversation
tristan-arm
commented
Apr 15, 2021
- Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release.
- Removed 20.08 driver stack support and updated all affected code.
a81bbfd
to
6f9116d
Compare
Test failure is due to the ci-cpu docker image using an outdated version of the ethos-n driver stack - should work fine if the docker image is recreated to account for changes to ubuntu_install_ethosn_driver_stack.sh @areusch Can look into updating the ci-cpu docker image - Thanks. |
cc @jroesch -- I think Jared is updating the images, but there is some challenge with GPU drivers right now that is blocking us. |
" 3 for Ethos-N78. See Ethos-N documentation.") | ||
TVM_ATTR_FIELD(variant).describe("See Ethos-N documentation.").set_default("Ethos-N77"); | ||
TVM_ATTR_FIELD(sram_size_bytes) | ||
.describe("Optionally override the default sram size. See Ethos-N documentation.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is defaulting the sram size to 0 the correct thing to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, zero is used by the ethos-n driver stack to indicate that the default sram size is not to be overridden.
@jroesch what's the status of ci-cpu update? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but @tristan-arm could you confirm this has been tested against upstream CI post the container update before I merge?
815a871
to
49c58d6
Compare
- Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release. - Removed 20.08 driver stack support and updated all affected code.
Sure, I've rebased and the tests are now green against the latest container updates. |
This is now merged. Thanks @tristan-arm |
…he#7858) - Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release. - Removed 20.08 driver stack support and updated all affected code.
…he#7858) - Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release. - Removed 20.08 driver stack support and updated all affected code.