Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHOSN] Removed support for 20.08 version of the driver stack. #7858

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

tristan-arm
Copy link
Contributor

  • Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release.
  • Removed 20.08 driver stack support and updated all affected code.

@tristan-arm
Copy link
Contributor Author

Test failure is due to the ci-cpu docker image using an outdated version of the ethos-n driver stack - should work fine if the docker image is recreated to account for changes to ubuntu_install_ethosn_driver_stack.sh

@areusch Can look into updating the ci-cpu docker image - Thanks.

@areusch
Copy link
Contributor

areusch commented Apr 20, 2021

cc @jroesch -- I think Jared is updating the images, but there is some challenge with GPU drivers right now that is blocking us.

@tristan-arm
Copy link
Contributor Author

cc @leandron @Leo-arm @u99127

@u99127
Copy link
Contributor

u99127 commented Apr 21, 2021

@mbaret

" 3 for Ethos-N78. See Ethos-N documentation.")
TVM_ATTR_FIELD(variant).describe("See Ethos-N documentation.").set_default("Ethos-N77");
TVM_ATTR_FIELD(sram_size_bytes)
.describe("Optionally override the default sram size. See Ethos-N documentation.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is defaulting the sram size to 0 the correct thing to do?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, zero is used by the ethos-n driver stack to indicate that the default sram size is not to be overridden.

@areusch
Copy link
Contributor

areusch commented Apr 30, 2021

@jroesch what's the status of ci-cpu update?

@areusch
Copy link
Contributor

areusch commented Jun 4, 2021

@mbaret @leandron @u99127 @Leo-arm the CI container has been updated, please take a look at this PR when you have a chance!

Copy link
Contributor

@mbaret mbaret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but @tristan-arm could you confirm this has been tested against upstream CI post the container update before I merge?

  - Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release.
  - Removed 20.08 driver stack support and updated all affected code.
@tristan-arm
Copy link
Contributor Author

LGTM, but @tristan-arm could you confirm this has been tested against upstream CI post the container update before I merge?

Sure, I've rebased and the tests are now green against the latest container updates.

@mbaret mbaret merged commit d69011d into apache:main Jun 11, 2021
@mbaret
Copy link
Contributor

mbaret commented Jun 11, 2021

This is now merged. Thanks @tristan-arm

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
…he#7858)

- Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release.
  - Removed 20.08 driver stack support and updated all affected code.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
…he#7858)

- Replaced capabilities header file with api calls introduced by the 20.11 ethosn driver stack release.
  - Removed 20.08 driver stack support and updated all affected code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants